HEEDLS-445 Edit course options

[showkath10]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-445

Description

Added new page that will allow user to edit course options

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[DanBloxham-sw]

Still a bunch of things to tackle.

[DanBloxham-sw]

From before: there is a subtlety here that is easy to miss.
The formatter will preserve any manually entered spaces. So running the formatter will keep the space you have added.
However, if you were to remove the space, running the formatter would not automatically re-add the space. That is the issue we are trying to solve here. We want the formatter to automatically add the space.

In order for that to happen, we need to change the formatter settings. These are stored in the .editorconfig file and can be edited interactively from:
Resharper options > Code Editing > General Formatter Style > Edit .editorconfig interactively
You then need to change the appropriate option so that the space is automatically added and save it to the .editorconfig file.

Let me know if you have any difficulty with this.

[showkath10]

I ran the formatter. Thanks for the advice. Yes, I have configured it now.

[DanBloxham-sw]

Could you configure it so that the .editorconfig registers the change? That way when this gets merged into master everyone will have it formatted consistently.

[DanBloxham-sw]

Some things need further changes and some things still need changing that have been missed. Any comments that have not been unresolved need some changes.

Also, there is a unit test failing. It is the one I mentioned in a missed comment that could be removed, so it can be easily dealt with. But in future you really should run all unit tests and make sure there aren't any failures before getting something re-reviewed.

[DanBloxham-sw]

Could you configure it so that the .editorconfig registers the change? That way when this gets merged into master everyone will have it formatted consistently.

[DanBloxham-sw]

Still a couple of things from before that I have left the comments unresolved for.

One is on the ManageCourseControllerTests file (the comment might be obscured in a Hidden Conversations block)

The other is the .editorconfig file is still not showing any changes. I'm happy to lend a hand here if you'd like.

[DanBloxham-sw]

Nice! Feel free to merge.