Skip to content

Conversation

@JBsoftwire
Copy link
Contributor

@JBsoftwire JBsoftwire commented Nov 2, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-408

Description

Added a new action to the tracker api endpoint that returns specified data, and relevant tests.

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@JBsoftwire
Copy link
Contributor Author

I haven't made the names more descriptive given our conversation about how they match the API specification, are independent from other parts of the system, and that I don't actually know what they are so I'd have to either ask HEE or guess.

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge away!

@JBsoftwire JBsoftwire merged commit 319ad94 into master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants