-
Notifications
You must be signed in to change notification settings - Fork 1
Heedls 657 add course to group page 2 #720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkinsm
reviewed
Nov 12, 2021
DigitalLearningSolutions.Data.Tests/Services/UserServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/UserServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/UserServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/DelegateGroupsController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/DelegateGroupsController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/DelegateGroupsController.cs
Outdated
Show resolved
Hide resolved
...earningSolutions.Web/ViewModels/TrackingSystem/Delegates/DelegateGroups/AddCourseFormData.cs
Outdated
Show resolved
Hide resolved
...arningSolutions.Web/ViewModels/TrackingSystem/Delegates/DelegateGroups/AddCourseViewModel.cs
Outdated
Show resolved
Hide resolved
wilkinsm
approved these changes
Nov 18, 2021
SteveJacksonSoft
suggested changes
Nov 26, 2021
DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/DelegateGroupsController.cs
Show resolved
Hide resolved
...arningSolutions.Web/ViewModels/TrackingSystem/Delegates/DelegateGroups/AddCourseViewModel.cs
Outdated
Show resolved
Hide resolved
...ingSolutions.Web.Tests/Controllers/TrackingSystem/Delegates/DelegateGroupsControllerTests.cs
Outdated
Show resolved
Hide resolved
SteveJacksonSoft
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-657
Description
Page 2 of the Add Course to Group journey.
Also fixes the incorrect supervisor list on the Edit Supervisor page https://softwiretech.atlassian.net/browse/HEEDLS-665
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: