Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Nov 11, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-657

Description

Page 2 of the Add Course to Group journey.

Also fixes the incorrect supervisor list on the Edit Supervisor page https://softwiretech.atlassian.net/browse/HEEDLS-665

Screenshots

image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@AlexJacksonDS AlexJacksonDS changed the base branch from master to release-22.1.1 December 1, 2021 16:26
@AlexJacksonDS AlexJacksonDS changed the base branch from release-22.1.1 to master December 1, 2021 16:26
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it.

@AlexJacksonDS AlexJacksonDS merged commit 30cf3d3 into master Dec 2, 2021
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-657-add-course-to-group-page-2 branch December 2, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants