-
Notifications
You must be signed in to change notification settings - Fork 1
Develop/feature/dlsv2 404 view supervisor verification comments #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop/feature/dlsv2 404 view supervisor verification comments #730
Conversation
…rificationComments
This reverts commit 0832ed9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can now navigate to the view notes page and return to the overview using the breadcrumbs.
Something strange is still going on with routing, though. The “View notes” link in the Overview view has a route value “competencyNumber” which doesn’t match the competencyNumber route value for the Review link in the next column.
When I follow the link, competencyNumber is appended as a query parameter “?competencyNumber=3“ instead of being handled in the routing. If it is included, it should appear in the URL routing before the {resultId}. E.g. SelfAssessment/4/Proficiencies/{competencyNumber}/123/ViewNotes.
The link to the Overview page in the breadcrumbs should be using this competencyNumber as its URL fragment (it is currently picking up a completely different value - asp-fragment="comp-@Model.SupervisorComment.CandidateID")
We are also missing a Back link in place of the breadcrumbs when the View Notes page is shrunk to mobile sizes. Please take a look at how this is implemented in other views so that it can be implemented here too.
Finally, please could you update the PR on GitHub to replace the placeholder text with text relating to your PR and check off the Developer checks that you have undertaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cancel button on the View Notes page is also linking to the wrong page. It should take me back to the SelfAssessmentOverview view but it takes me back to my Current Activities list.
JIRA link
DLSV2-404
Description
Implements view verifier comments view with link from self assessment overview table.
Screenshots