Skip to content

Conversation

@ynhemanth
Copy link

@ynhemanth ynhemanth commented Nov 23, 2021

JIRA link

DLSV2-424

Description

Added new migration to increase SignOffRequestorStatement and SignOffSupervisorStatement fields length from nvarchar(1000) to nvarchar(2000) on Selfassessment table

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but only adjusts the length of one of the two fields specified.
Also, please could you update the description of the PR (it has placeholder text at the moment).
Thanks

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved this, though it's not ideal. Changes being made to address one ticket should really have been done in one migration rather than two separate ones but it won't matter as a one-off.

@kevwhitt-hee kevwhitt-hee merged commit 052566a into master Nov 24, 2021
SteveJacksonSoft added a commit that referenced this pull request Nov 24, 2021
…Develop/feature/DLSV2-424-increase-length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants