Skip to content

Heedls 570 Edit course completion date #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 9, 2021
Merged

Heedls 570 Edit course completion date #757

merged 19 commits into from
Dec 9, 2021

Conversation

@rhimcg
Copy link
Contributor

@rhimcg rhimcg commented Nov 25, 2021 •
edited
Loading

JIRA link

HEEDLS-570(https://softwiretech.atlassian.net/jira/software/c/projects/HEEDLS/boards/671?modal=detail&selectedIssue=HEEDLS-570&assignee=6065c334b30f0d00704264d4)

Description

Edit completion date from view delegate or course delegate screen

Screenshots

image

Doesn't let you say a course has been completed in the future (but the course name disappears)
image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

AlexJacksonDS
AlexJacksonDS suggested changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably also have the Delegate name on the page, so that it matches the other Progress value edit pages (Supervisor and Complete By).

A few other things to tidy up.

@rhimcg
Copy link
Contributor Author

rhimcg commented Nov 29, 2021

I think we should probably also have the Delegate name on the page, so that it matches the other Progress value edit pages (Supervisor and Complete By).

A few other things to tidy up.

cool added that
image

AlexJacksonDS
AlexJacksonDS suggested changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things I missed last time, check the previous unresolved comments too.

@rhimcg rhimcg requested a review from AlexJacksonDS November 30, 2021 15:02
AlexJacksonDS
AlexJacksonDS reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one issue left to resolve with a failing accessibility test

@rhimcg rhimcg requested a review from AlexJacksonDS November 30, 2021 16:15
wilkinsm
wilkinsm suggested changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@wilkinsm wilkinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few minor points to look through.

@rhimcg rhimcg requested a review from wilkinsm December 7, 2021 09:07
wilkinsm
wilkinsm approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@wilkinsm wilkinsm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once the merge conflicts are dealt with.

rhimcg added 2 commits December 9, 2021 16:36
@rhimcg
Merge branch 'master' into HEEDLS-570
46448ad 
# Conflicts:
#	DigitalLearningSolutions.Data.Tests/Services/ProgressServiceTests.cs
#	DigitalLearningSolutions.Data/Services/CourseService.cs
#	DigitalLearningSolutions.Data/Services/ProgressService.cs
#	DigitalLearningSolutions.Web.AutomatedUiTests/AccessibilityTests/BasicAuthenticatedAccessibilityTests.cs
#	DigitalLearningSolutions.Web.Tests/Controllers/TrackingSystem/Delegates/DelegateProgressControllerTests.cs
#	DigitalLearningSolutions.Web/Controllers/TrackingSystem/Delegates/DelegateProgressController.cs
@rhimcg
Merge branch 'master' into HEEDLS-570
f4335de
@rhimcg rhimcg merged commit da1c6e5 into master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@wilkinsm wilkinsm wilkinsm approved these changes

@AlexJacksonDS AlexJacksonDS AlexJacksonDS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rhimcg @wilkinsm @AlexJacksonDS