Develop/features/dlsv2 421 required competency assessment questions in self assessment overview #774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iding whether to show the Request Sign-off button in SelfAssessmentOverview
…iding whether to show the Request Sign-off button in SelfAssessmentOverview
kevwhitt-hee
approved these changes
Nov 30, 2021
kevwhitt-hee
deleted the
Develop/Features/DLSV2-421-RequiredCompetencyAssessmentQuestionsInSelfAssessmentOverview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-421
Description
Created migration for adding Required field to database table CompetencyAssessmentQuestions. Modified the logics to show and hide "Request [role] sign-off" button on view SelfAssessmentOverview.cshtml. Now it only checks for a verified result when the assessment question is Required.
Screenshots
Developer checks
Navigate to Learning portal / Launch self assessment / View capabilities. Check that even when some assessment questions are not verified, the button "Request [role] sign-off" can be seen when these questions are not required.