Heedls 686 prn add to edit details for delegates #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

wilkinsm merged 22 commits into master from HEEDLS-686-PRN-add-to-edit-details-for-delegates

Jan 19, 2022

Contributor

showkath10 commented Dec 8, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-686

Description

Added new radio buttons and professional registration box which will only be required when user selects Yes
Professional registration has validation (must be between 5 and 20 characters allowed, only alphanumeric and hyphens allowed)
Professional registration also added to details card (this is not mentioned in the ticket)

Screenshots

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

Run the formatter and made sure there are no IDE errors.
Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
- doc_1_here
Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
Scanned over my own MR to ensure everything is as expected.

showkath10 changed the base branch from master to release-22.1.1

December 8, 2021 06:51

davidm-m suggested changes

View reviewed changes

Contributor

davidm-m left a comment

A few questions and things I think could be tidied up

...arningSolutions.Data.Tests/DataServices/UserDataServiceTests/DelegateUserDataServiceTests.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Controllers/MyAccountController.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/ViewModels/MyAccount/EditDetailsFormData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

davidm-m suggested changes

View reviewed changes

Contributor

davidm-m left a comment

Still needs some tweaks to how we display error messages on the radio buttons, but the other changes are good.

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

Base automatically changed from release-22.1.1 to master

December 16, 2021 10:16

davidm-m suggested changes

View reviewed changes

Contributor

davidm-m left a comment

Still some changes to be made to how we display errors on the view

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

showkath10 added 8 commits

December 17, 2021 15:30


          HEEDLS-686 PRN-add-to-edit-details

b8c6b8d


          HEEDLS-686 PRN add to edit details for delegates

a8f57fc


          Removed view model which was never used and updated format for view

0b41993


          Code changes done as suggested in peer review

d191e59


          Change the view validation for select an option

bed581a


          Updated model view validation logic

269f9ab


          Added hint for professional registration number

34d4c55


          Merged HEEDLS-686 to master

07d9772

showkath10 force-pushed the HEEDLS-686-PRN-add-to-edit-details-for-delegates branch from c785587 to 07d9772 Compare

December 17, 2021 17:59

showkath10 and others added 6 commits

December 17, 2021 18:06


          Updated changes as suggested by preer-review

68b032b


          HEEDLS-686 Markup additions

cefbcc3


          HEEDLS-686 Markup changes

fc2a529


          Merge branch 'master' into HEEDLS-686-PRN-add-fields-to-myaccount-rf

cd75e44


          HEEDLS-686 Refactor validation

828c72e


          HEEDLS-686 clean up

0292da5

davidm-m suggested changes

View reviewed changes

Contributor

davidm-m left a comment

A few really small things to fix but overall looks great.

DigitalLearningSolutions.Web/Helpers/CentreCustomPromptHelper.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/ViewModels/MyAccount/MyAccountEditDetailsFormData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/EditDetails.cshtml Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Outdated Show resolved Hide resolved

Martin Wilkins added 2 commits

January 11, 2022 20:41


          HEEDLS-686 Markups

6dda5f7


          Merge branch 'master' into HEEDLS-686-PRN-add-to-edit-details-for-del…

a54dca0

…egates

davidm-m approved these changes

View reviewed changes

Contributor

davidm-m left a comment

Fantastic stuff

SteveJacksonSoft suggested changes

View reviewed changes

DigitalLearningSolutions.Web/Helpers/CentreCustomPromptHelper.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Data/Models/User/MyAccountDetailsData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_EditRegistrationNumber.cshtml Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_MyDetailsCard.cshtml Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/ViewModels/MyAccount/MyAccountEditDetailsFormData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/ViewModels/MyAccount/MyAccountEditDetailsFormData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/ViewModels/MyAccount/MyAccountEditDetailsFormData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/ViewModels/MyAccount/MyAccountEditDetailsFormData.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Attributes/RunValidateMethodAttribute.cs Outdated Show resolved Hide resolved

Martin Wilkins added 3 commits

January 18, 2022 13:39


          HEEDLS-686 TLR Markups

83d2469


          Merge branch 'master' into HEEDLS-686-PRN-add-to-edit-details-for-del…

96ac373

…egates


          HEEDLS-686 refactor prn validation

2f6ecd8

SteveJacksonSoft reviewed

View reviewed changes

DigitalLearningSolutions.Web/Helpers/ProfessionalRegistrationNumberHelper.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Views/MyAccount/_MyDetailsCard.cshtml Outdated Show resolved Hide resolved

SteveJacksonSoft reviewed

View reviewed changes

Contributor

SteveJacksonSoft left a comment

Couple of things I'd tweak just. Nice test cases!

DigitalLearningSolutions.Web.Tests/Helpers/ProfessionalRegistrationNumberHelperTests.cs Outdated Show resolved Hide resolved


          HEEDLS-686 TLR markups - prn fix

30f564c

wilkinsm reviewed

View reviewed changes

DigitalLearningSolutions.Web/Helpers/AccountDetailsDataHelper.cs Show resolved Hide resolved

SteveJacksonSoft reviewed

View reviewed changes

DigitalLearningSolutions.Web.Tests/Helpers/ProfessionalRegistrationNumberHelperTests.cs Outdated Show resolved Hide resolved

DigitalLearningSolutions.Web/Helpers/AccountDetailsDataHelper.cs Show resolved Hide resolved

Martin Wilkins added 2 commits

January 19, 2022 14:30


          HEEDLS-686 TLR Markups

c18e1d4


          Merge branch 'master' into HEEDLS-686-PRN-add-to-edit-details-for-del…

…egates

wilkinsm merged commit b36fa1e into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet