-
Notifications
You must be signed in to change notification settings - Fork 1
Heedls 408: Fix change password bug introduced in previous HEEDLS-408 work #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
DigitalLearningSolutions.Data.Tests/DataServices/PasswordDataServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/DataServices/PasswordDataServiceTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things
DigitalLearningSolutions.Data.Tests/DataServices/PasswordDataServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/TestHelpers/UserTestHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
JIRA link
HEEDLS-408
Description
A type handler was added in the original HEEDLS-408 work which overrode how Dapper works with parameters of type
IEnumerable<int>. This broke change-password.I've replaced the type handler with a parse in the constructor of
Objective.I've also added a couple of tests and made the
ObjectiveBaseclass abstract, since we aren't instantiating it and I don't expect we ever will.Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: