Skip to content

Conversation

@SteveJacksonSoft
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft commented Dec 8, 2021

JIRA link

HEEDLS-408

Description

A type handler was added in the original HEEDLS-408 work which overrode how Dapper works with parameters of type IEnumerable<int>. This broke change-password.
I've replaced the type handler with a parse in the constructor of Objective.

I've also added a couple of tests and made the ObjectiveBase class abstract, since we aren't instantiating it and I don't expect we ever will.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@JBsoftwire JBsoftwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SteveJacksonSoft SteveJacksonSoft merged commit 9eacfca into master Dec 14, 2021
@SteveJacksonSoft SteveJacksonSoft deleted the HEEDLS-408-fix-change-password-bug branch December 14, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants