Skip to content

Conversation

@DanBloxham-sw
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw commented Dec 10, 2021

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-671

Description

In 671 I mistakenly removed a Signposting config check from a method that it should not have been removed from. This MR adds the check back.

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Comment on lines 105 to 108
if (!config.IsSignpostingUsed())
{
return new List<ActionPlanResource>();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a strong preference to put the gate in here rather than where this method is used? It feels like this method shouldn't be being called if signposting isn't enabled.

I think it's worth updating the name of the method if you're putting the gate in here. I generally wouldn't expect a service method to conk out if a config flag is set unless it explicitly says so.

Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about mocked config values

Copy link
Contributor

@livzorn livzorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@DanBloxham-sw DanBloxham-sw merged commit f7e067b into master Dec 14, 2021
@DanBloxham-sw DanBloxham-sw deleted the HEEDLS-671-FixCurrentPageWhenSignpostingDisabled branch December 14, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants