-
Notifications
You must be signed in to change notification settings - Fork 1
Heedls 681 Add LH SSO Account Linking Endpoint #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ount-Linnking-Endpoint
|
Need to write up about the new Integration Tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of things I noticed about the tests.
DigitalLearningSolutions.Data.Tests/Services/LearningHubSsoSecurityServiceTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
DigitalLearningSolutions.Web/Controllers/Signposting/LinkLearningHubSsoController.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at everything except integration tests so far.
DigitalLearningSolutions.Data/Services/LearningHubSsoSecurityService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/Services/LearningHubSsoSecurityService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/Services/LearningHubSsoSecurityService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data/Services/LearningHubSsoSecurityService.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Controllers/Signposting/LinkLearningHubSsoController.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/Signposting/LinkLearningHubSso/Index.cshtml
Outdated
Show resolved
Hide resolved
...lLearningSolutions.Web/ViewModels/Signposting/LinkLearningHubSso/LinkLearningHubViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/LearningHubSsoSecurityServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/LearningHubSsoSecurityServiceTests.cs
Outdated
Show resolved
Hide resolved
...arningSolutions.Data.Tests/DataServices/UserDataServiceTests/DelegateUserDataServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/LearningHubLinkServiceTests.cs
Outdated
Show resolved
Hide resolved
...arningSolutions.Data.Tests/DataServices/UserDataServiceTests/DelegateUserDataServiceTests.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web.IntegrationTests/AuthenticationWebApplicationFactory.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web.IntegrationTests/TestHelpers/TestUserApp.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web.IntegrationTests/CustomWebApplicationFactory.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web.IntegrationTests/TestHelpers/TestUserApp.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web.IntegrationTests/AuthenticationWebApplicationFactory.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, think it's just the two already-existing threads to resolve.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-681
Description
Add new endpoint that recieves requests from the LH that links the LH accounts to the DLS accounts.
This is part of the overall Learning Hub SSO linking journey.
Screenshots
Desktop standard

Desktop Already Linked

Desktop Invalid resource id

Tablet

Mobile

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: