Heedls 711 filter results outside range

[AlexJacksonDS]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-711

Description

Filtering of resources where the delegate answer falls outside the range of results specified in CompetencyResourceAssessmentQuestionParameters. Refactored and added new unit tests to accommodate these changes.

Screenshots

No visual changes

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[DanBloxham-sw]

Looks just about how I was expecting, though I've left a few comments to tackle.

[DanBloxham-sw]

This test title mentions "...correct score for {factor} only" but the expected scores seem to be higher than just the individual factor's contribution, so might be worth renaming.

[AlexJacksonDS]

This was a consequence of me not realising the relationship was 1-1-0 (The Single comment above)
We now have 2 basic situations, either we can only calc the score from the LH rating, or we can have the LH rating + attempt both other values (req adj may be 0).
Restored these back to just the LH calculation, dropping the QuestionParameters setup.

[DanBloxham-sw]

Ah I see, the case where no QuestionParameters are set up is handled here. I think given that that case is specifically considered in the logic for determining what to hide, it might be good to specify it in the title here then. Just will make it easier to see that it has indeed be tested from a quickly glance.
Maybe something like "...for_resource_only_with_learning_hub_rating_and_no_question_parameters"?

[DanBloxham-sw]

Nice, think this covers everything now.

[livzorn]

Looks good!