Skip to content

Heedls 658 add course to group page 3 #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 1, 2022
Merged

Heedls 658 add course to group page 3 #868

merged 10 commits into from
Feb 1, 2022

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Jan 19, 2022 •
edited
Loading

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-658

Description

Added the Save and confirmation page of the Add Course to group journey. I've refactored out the GroupCoursesController from the DelegateGroupsController in a similar fashion to the refactor of the GroupDelegatesController in HEEDLS-514 (Add delegate to group, in review)

This may conflict slightly with that MR so might need to resolve some stuff later.

Screenshots

image
image
image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

DanBloxham-sw
DanBloxham-sw suggested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I've covered everything, though I imagine I've missed something in the big test file

DanBloxham-sw
DanBloxham-sw suggested changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, few small follow ups.

wilkinsm
wilkinsm suggested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@wilkinsm wilkinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Alex, just a new suggestions to look at really.

wilkinsm
wilkinsm approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@wilkinsm wilkinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex, looks good to merge.

@AlexJacksonDS AlexJacksonDS merged commit a004ae9 into master Feb 1, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-658-add-course-to-group-page-3 branch February 1, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@wilkinsm wilkinsm wilkinsm approved these changes

@DanBloxham-sw DanBloxham-sw DanBloxham-sw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexJacksonDS @wilkinsm @DanBloxham-sw