HEEDLS-709 - change tab title and button role

[DanBloxham-sw]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-709

Description

Changed the tab title and added role=link to the launch resource button so that it as announced as a link.

Screenshots

N/A - no visual changes made

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[AlexJacksonDS]

Looks fine, but does this fix the issue with the submit behaviour I found when I was testing this?

[DanBloxham-sw]

Looks fine, but does this fix the issue with the submit behaviour I found when I was testing this?

Somehow, I didn't spot that part of the comment, and thus hadn't attempted to fix it. My bad.

I've tried replicating the issue on this branch and on hee-dls-test, and can't seem to get the failing behaviour to occur. From what I can see, hitting enter submits the form as it should, updating the dismissal flag if the checkbox is selected - am I misinterpreting something here?

[AlexJacksonDS]

The mentioned submission behaviour is something to do with the screen reader and affects other pages. It seems like intended behaviour causes by the screen reader. Will comment this on the ticket too.