Heedls 687 self registration prn #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexJacksonDS
commented
Jan 24, 2022
| AliasID = @aliasId, | ||
| EmailAddress = @emailAddress | ||
| WHERE CandidateID = @delegateId", | ||
| FirstName = @firstName, |
There was a problem hiding this comment.
This is just fixing mixed tabs and spaces in the file
DanBloxham-sw
suggested changes
Jan 25, 2022
DigitalLearningSolutions.Data.Tests/Services/RegistrationServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/Shared/_EditRegistrationNumber.cshtml
Show resolved
Hide resolved
DanBloxham-sw
approved these changes
Jan 25, 2022
wilkinsm
suggested changes
Jan 27, 2022
DigitalLearningSolutions.Data.Tests/Services/RegistrationServiceTests.cs
Outdated
Show resolved
Hide resolved
wilkinsm
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-687
Description
Added the PRN fields to the Learner Information page of the delegate self registration journey by moving the partial created for the My Account Edit Details page to a shared location and using that.
Added an entry for this new value in the Summary view
Updated the service logic to make a call to save the provided value rather than updating the register candidate stored procedure.
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: