Skip to content

HEEDLS-687 Fix error message for invalid characters #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2022
Merged

HEEDLS-687 Fix error message for invalid characters #899

merged 1 commit into from
Jan 31, 2022

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Jan 28, 2022 •
edited
Loading

JIRA link

HEEDLS-XXXX

Description

Fixed the error message for invalid characters in PRNs

Screenshots

image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

DanBloxham-sw
DanBloxham-sw approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

wilkinsm
wilkinsm approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@wilkinsm wilkinsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@AlexJacksonDS AlexJacksonDS merged commit d19c905 into master Jan 31, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-687-self-registration-prn branch January 31, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@wilkinsm wilkinsm wilkinsm approved these changes

@DanBloxham-sw DanBloxham-sw DanBloxham-sw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexJacksonDS @wilkinsm @DanBloxham-sw