-
Notifications
You must be signed in to change notification settings - Fork 1
HEEDLS-500 - implement learning log page for delegate progress #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things to tidy up, but looks fine overall
DigitalLearningSolutions.Data/DataServices/ProgressDataService.cs
Outdated
Show resolved
Hide resolved
...Tests/ViewModels/TrackingSystem/Delegates/DelegateProgress/LearningLogEntryViewModelTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/Delegates/DelegateProgress/LearningLog.cshtml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked at tests yet, but this is all I got on everything else. Looks nice!
...ngSolutions.Web/ViewModels/TrackingSystem/Delegates/DelegateProgress/LearningLogViewModel.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Scripts/searchSortFilterAndPaginate/searchSortFilterAndPaginate.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the tests now as well.
DigitalLearningSolutions.Web.Tests/Helpers/DisplayStringHelperTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, merge away.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-500
Description
Implemented new page for the delegate progress learning log. Cleaned up a couple of unrelated pages as well with the formatter.
Slightly modified the SearchSortFilterPaginate JS to work with the table here. Required surprisingly few modifications, mostly making sure that unnecessary logic is not executed when pagination is set to false.
Screenshots
Desktop:

Tablet:

Mobile:

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: