Heedls 500 learning log test fixes

[DanBloxham-sw]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-500

Description

Fixed the issue raised in test that JS sorting by When did not take the hours/minutes/seconds into account. I've replaced the old parseDate method with one that takes considers hours/minutes/seconds. I've double checked, and this does not break places where we only display the date without the time.

Screenshots

N/A

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[livzorn]

Looks good

[AlexJacksonDS]

Looks good to me, I assume the new parse function works as expected with just date strings since the sort typescript tests pass?

[DanBloxham-sw]

Looks good to me, I assume the new parse function works as expected with just date strings since the sort typescript tests pass?

Yep, I looked at the Current activities page and sorted by the various dates, and all were placed in the correct order each time.