-
Notifications
You must be signed in to change notification settings - Fork 1
HEEDLS-609 : Move ConfigHelper to the data project #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that I think should have been done that are not yet done, and some files are now in the wrong place following the changes.
Also a query about whether we've done the correct thing here for Steve.
DigitalLearningSolutions.Data.Tests/Services/ConfigServiceTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Data.Tests/Services/GroupServiceTests/GroupsServiceTests.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Data/Helpers/ConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
|
I don't have any new comments to add to what Alex said, just to make sure you deal with the merge conflicts as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good now, you've just still got another merge conflict to resolve since the last merge from master
JIRA link
HEEDLS-609
Description
A technical debt ticket to move functionality from
ConfigHelpertoConfigurationExtensionsin the data project.Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: