Skip to content

Conversation

@daniel-manta-hee
Copy link
Contributor

@daniel-manta-hee daniel-manta-hee commented Mar 1, 2022

JIRA link

https://hee-dls.atlassian.net/browse/DLSV2-513

Description

Added migration, updated tests, views, controller methods and helpers.

Screenshots

Administrator/EditAdminRoles.cshtml

image

Delegates/PromoteToAdmin/Index.cshtml

image


Developer checks

I have:

  • Run Data and Web tests.
  • Checked Add staff members not available in Supervisor/MyStaffList.cshtml when user is nominated supervisor.
  • Checked that Enrol on self assessments not available in Supervisor/DelegateProfileAssessments.cshtml when user is nominated supervisor.
  • Checked that new role Is Nominated Supervisor is available in Administrator/EditAdminRoles.cshtml.
  • Checked that new role Is Nominated Supervisor is available in Delegates/PromoteToAdmin/Index.cshtml.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tweaks requested in comments and one question.

@kevwhitt-hee kevwhitt-hee merged commit b2d8e1d into master Mar 2, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Features/DLSV2-513-NominatedSupervisorRole branch March 2, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants