Skip to content

TD-169 GDSMultiPageFormService solution added. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 11, 2022
Merged

TD-169 GDSMultiPageFormService solution added. #1

merged 12 commits into from
Nov 11, 2022

Conversation

@Auldrin-Possa
Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa commented Nov 9, 2022 •
edited by kevwhitt-hee
Loading

JIRA link
https://hee-tis.atlassian.net/browse/TD-169

Description
GDSMultiPageFormService solution added.

Screenshots
N/A

Developer checks
I have:

  • Run the formatter and made sure there are no IDE errors
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with [Wave Chrome plugin]
  • Updated/added documentation in [Confluence]
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my own MR to ensure everything is as expected and it looks right in the browser

@Auldrin-Possa
GDSMultiPageFormService solution added.
6fdd95c 
GDSMultiPageFormService solution added.
kevwhitt-hee
kevwhitt-hee requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few files with no new line at end of file warnings in Github. Please could we fix these?

@kevwhitt-hee kevwhitt-hee changed the title GDSMultiPageFormService solution added. TD-169 GDSMultiPageFormService solution added. Nov 11, 2022
@kevwhitt-hee kevwhitt-hee merged commit 78c11c4 into main Nov 11, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Fix/TD-169-MultiPageForm-nuget-package branch November 11, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevwhitt-hee kevwhitt-hee kevwhitt-hee requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Auldrin-Possa @kevwhitt-hee