Skip to content

Conversation

@OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented Aug 25, 2023

JIRA link

TD-1884

Description

The file was updated to have a custom field which can be updated from any external code consuming the nuget package by providing a unique string name.

  • For an action method filter, [TypeFilter(typeof(RedirectMissingMultiPageFormData), Arguments = new object[] { "newaccountCWF" })]
  • To get data, await this.multiPageFormService.GetMultiPageFormData<AccountCreationViewModel>(MultiPageFormDataFeature.AddCustomWebForm("newaccountCWF"), this.TempData);
  • To save data, await this.multiPageFormService.SetMultiPageFormData(newAccooount,MultiPageFormDataFeature.AddCustomWebForm("newaccountCWF"),this.TempData);

The reason for the CWF constraint in the code is to ensure the form-name do not conflict with any of the existing predefined fields in the MultiPageFormDataFeature class.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@OluwatobiAwe
Copy link
Collaborator Author

@kevwhitt-hee I manually deleted some files and folders that were already in the repo before the gitignore file was added, so the updates might be difficult to track. The only file that changed is
GDSMultiPageFormService/Enums/MultiPageFormDataFeature.cs

@OluwatobiAwe OluwatobiAwe merged commit 48161eb into main Aug 30, 2023
@OluwatobiAwe OluwatobiAwe deleted the Develop/Feature/TD-1884 branch August 30, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants