Skip to content

Conversation

@OluwatobiAwe
Copy link
Collaborator

@OluwatobiAwe OluwatobiAwe commented Jan 9, 2023

JIRA link

TD-878

Description

Adapt multipage form-service package to use redis.
Relies on LearningHub.Nhs.Caching nuget package to connect to the redis cache

Screenshots

nil


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link
Collaborator

@Auldrin-Possa Auldrin-Possa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@OluwatobiAwe OluwatobiAwe merged commit 184d147 into main Jan 11, 2023
@OluwatobiAwe OluwatobiAwe deleted the TD-878 branch January 11, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants