Skip to content

Conversation

@akdalin-hee
Copy link
Contributor

JIRA link

TD-3158

Description

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

…t it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
Copy link
Contributor

@OluwatobiAwe OluwatobiAwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@akdalin-hee akdalin-hee merged commit 47a1228 into releases/phoenix Jan 19, 2024
AnjuJose011 pushed a commit that referenced this pull request Mar 13, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
AnjuJose011 pushed a commit that referenced this pull request Mar 14, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
AnjuJose011 pushed a commit that referenced this pull request Mar 21, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
AnjuJose011 pushed a commit that referenced this pull request Mar 21, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
AnjuJose011 pushed a commit that referenced this pull request Mar 21, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
AnjuJose011 pushed a commit that referenced this pull request Mar 21, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…ning-accessibility-fix

Move filter-summary outside of details tag. Amend itss styling so that it still appears in its default location relative to the adjacent elements. Make selector for "nhsuk-search__submit" more generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants