Skip to content

TD-5003: Issue showing 1 sec delay when played Video/Audio resources … #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

TD-5003: Issue showing 1 sec delay when played Video/Audio resources … #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions AdminUI/LearningHub.Nhs.AdminUI/Helpers/LearningActivityHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,15 @@ public static string GetResourceTypeVerb(this MyLearningDetailedItemViewModel my
case ResourceTypeEnum.Article:
return "Read";
case ResourceTypeEnum.Audio:
return "Played " + GetDurationText(myLearningDetailedItemViewModel.ActivityDurationSeconds * 1000);
if ((myLearningDetailedItemViewModel.ActivityDurationSeconds * 1000) > myLearningDetailedItemViewModel.ResourceDurationMilliseconds)
{
return "Played " + GetDurationText(myLearningDetailedItemViewModel.ResourceDurationMilliseconds);
}
else
{
return "Played " + GetDurationText(myLearningDetailedItemViewModel.ActivityDurationSeconds * 1000);
}

case ResourceTypeEnum.Embedded:
return string.Empty;
case ResourceTypeEnum.Equipment:
Expand Down Expand Up @@ -113,7 +121,15 @@ public static string GetResourceTypeVerb(this MyLearningDetailedItemViewModel my
}

case ResourceTypeEnum.Video:
return "Played " + GetDurationText(myLearningDetailedItemViewModel.ActivityDurationSeconds * 1000);
if ((myLearningDetailedItemViewModel.ActivityDurationSeconds * 1000) > myLearningDetailedItemViewModel.ResourceDurationMilliseconds)
{
return "Played " + GetDurationText(myLearningDetailedItemViewModel.ResourceDurationMilliseconds);
}
else
{
return "Played " + GetDurationText(myLearningDetailedItemViewModel.ActivityDurationSeconds * 1000);
}

case ResourceTypeEnum.WebLink:
return "Visited";
case ResourceTypeEnum.Html:
Expand Down
20 changes: 18 additions & 2 deletions LearningHub.Nhs.WebUI/Helpers/ViewActivityHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,15 @@ public static string GetResourceTypeVerb(this ActivityDetailedItemViewModel acti
case ResourceTypeEnum.Article:
return "Read";
case ResourceTypeEnum.Audio:
return "Played " + GetDurationText(activityDetailedItemViewModel.ActivityDurationSeconds * 1000);
if ((activityDetailedItemViewModel.ActivityDurationSeconds * 1000) > activityDetailedItemViewModel.ResourceDurationMilliseconds)
{
return "Played " + GetDurationText(activityDetailedItemViewModel.ResourceDurationMilliseconds);
}
else
{
return "Played " + GetDurationText(activityDetailedItemViewModel.ActivityDurationSeconds * 1000);
}

case ResourceTypeEnum.Embedded:
return string.Empty;
case ResourceTypeEnum.Equipment:
Expand Down Expand Up @@ -112,7 +120,15 @@ public static string GetResourceTypeVerb(this ActivityDetailedItemViewModel acti
}

case ResourceTypeEnum.Video:
return "Played " + GetDurationText(activityDetailedItemViewModel.ActivityDurationSeconds * 1000);
if ((activityDetailedItemViewModel.ActivityDurationSeconds * 1000) > activityDetailedItemViewModel.ResourceDurationMilliseconds)
{
return "Played " + GetDurationText(activityDetailedItemViewModel.ResourceDurationMilliseconds);
}
else
{
return "Played " + GetDurationText(activityDetailedItemViewModel.ActivityDurationSeconds * 1000);
}

case ResourceTypeEnum.WebLink:
return "Visited";
case ResourceTypeEnum.Html:
Expand Down
Loading