Skip to content

Conversation

@binon
Copy link
Collaborator

@binon binon commented Feb 28, 2024

JIRA link

TD-###

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

akdalin-hee and others added 30 commits January 30, 2024 17:59
…r-details-accessibility-fix

Correct autocomplete references in alignment to HTML best practices
…marks-accessibility-fix

Fix accessibility issues in My Bookmarks section
…-result-accessibility-fix

Fix learner search page and search results accessibility issues
…ogue-pages-accessibility-fix

Fix learner catalogue pages accessibility issues
…H/TD-3546-Azure-Log-Threads-are-mixing-synchronous-code-with-asynchronous-code

TD-3546: Azure Log -Threads are mixing synchronous code with asynchro…
…/LH-TD-3541-Zip-file-can-be-marked-as-SCORM-outdated-feature

TD-3541- Zip file can be marked as SCORM outdated feature
…earning-resources-accessibility-issues

Fix learning resources accessibility issues
kevwhitt-hee and others added 23 commits February 26, 2024 09:18
…TD-3676-UpdateOpenAPIBrandingAndLinks

TD-3676 Updates branding and links in the OpenAPI project to NHS England
…/TD-3726-Video-not-recording-progress-properly-and-returning-unknownerror

Develop/fixes/td 3726 video not recording progress properly and returning unknown error
…/TD-3744-Jobrolewithslashincauseserrorduringregistration

TD-3744-Job role with slash in causes error during registration
@binon binon merged commit 7a40e5c into Develop/Features/TD-2899-add_automated_accessibility_unit_testing_project Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants