Skip to content

Make buttons readable to Windows Narrator. Update NHS Learning Hub lo… #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes into CI
merged 1 commit into from
Mar 27, 2024
Merged

Make buttons readable to Windows Narrator. Update NHS Learning Hub lo… #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LearningHub.Nhs.WebUI/Views/Bookmark/_BookmarkAction.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<span class="action-link-chevron @(Model.IsFirst? "empty" : "")">
@if (Model.IsFirst == false)
{
<button name="action" value="moveup" class="btn btn-link action-link" title="Move up">
<button name="action" value="moveup" class="btn btn-link action-link" title="Move up" aria-label="Move up">
<i class="fa-solid fa-chevron-up fa-sm"></i>
</button>
}
Expand All @@ -15,7 +15,7 @@
<span class="action-link-chevron @(Model.IsLast? "empty" : "")">
@if (Model.IsLast == false)
{
<button name="action" value="movedown" class="btn btn-link action-link" title="Move down">
<button name="action" value="movedown" class="btn btn-link action-link" title="Move down" aria-label="Move down">
<i class="fa-solid fa-chevron-down fa-sm"></i>
</button>
}
Expand Down
6 changes: 3 additions & 3 deletions LearningHub.Nhs.WebUI/Views/MyLearning/LearningCertificate.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@
{
<div style="margin-top:20px" class="nhsuk-grid-column-full certificateHead">
<div class="nhsuk-header__logo nhsuk-u-padding-3">
<a style="width:auto" class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS homepage">
<a style="width:auto" class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS Learning Hub homepage">
<svg class="nhsuk-logo" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 16" height="40" width="100">
<path class="nhsuk-logo__background" fill="#005eb8" d="M0 0h40v16H0z"></path>
<path class="nhsuk-logo__text" fill="#fff" d="M3.9 1.5h4.4l2.6 9h.1l1.8-9h3.3l-2.8 13H9l-2.7-9h-.1l-1.8 9H1.1M17.3 1.5h3.6l-1 4.9h4L25 1.5h3.5l-2.7 13h-3.5l1.1-5.6h-4.1l-1.2 5.6h-3.4M37.7 4.4c-.7-.3-1.6-.6-2.9-.6-1.4 0-2.5.2-2.5 1.3 0 1.8 5.1 1.2 5.1 5.1 0 3.6-3.3 4.5-6.4 4.5-1.3 0-2.9-.3-4-.7l.8-2.7c.7.4 2.1.7 3.2.7s2.8-.2 2.8-1.5c0-2.1-5.1-1.3-5.1-5 0-3.4 2.9-4.4 5.8-4.4 1.6 0 3.1.2 4 .6"></path>
Expand Down Expand Up @@ -1276,7 +1276,7 @@
}
<div class="nhsuk-grid-column-full certificateHead">
<div class="nhsuk-header__logo nhsuk-u-padding-3">
<a style="width:auto" class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS homepage">
<a style="width:auto" class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS Learning Hub homepage">
<svg class="nhsuk-logo" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 16" height="40" width="100">
<path class="nhsuk-logo__background" fill="#005eb8" d="M0 0h40v16H0z"></path>
<path class="nhsuk-logo__text" fill="#fff" d="M3.9 1.5h4.4l2.6 9h.1l1.8-9h3.3l-2.8 13H9l-2.7-9h-.1l-1.8 9H1.1M17.3 1.5h3.6l-1 4.9h4L25 1.5h3.5l-2.7 13h-3.5l1.1-5.6h-4.1l-1.2 5.6h-3.4M37.7 4.4c-.7-.3-1.6-.6-2.9-.6-1.4 0-2.5.2-2.5 1.3 0 1.8 5.1 1.2 5.1 5.1 0 3.6-3.3 4.5-6.4 4.5-1.3 0-2.9-.3-4-.7l.8-2.7c.7.4 2.1.7 3.2.7s2.8-.2 2.8-1.5c0-2.1-5.1-1.3-5.1-5 0-3.4 2.9-4.4 5.8-4.4 1.6 0 3.1.2 4 .6"></path>
Expand Down Expand Up @@ -1320,7 +1320,7 @@
<div>
<div class="nhsuk-grid-column-full certificateHead">
<div class="nhsuk-header__logo nhsuk-u-padding-3">
<a class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS homepage">
<a class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS Learning Hub homepage">
<svg class="nhsuk-logo" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 16" height="40" width="100">
<path class="nhsuk-logo__background" fill="#005eb8" d="M0 0h40v16H0z"></path>
<path class="nhsuk-logo__text" fill="#fff" d="M3.9 1.5h4.4l2.6 9h.1l1.8-9h3.3l-2.8 13H9l-2.7-9h-.1l-1.8 9H1.1M17.3 1.5h3.6l-1 4.9h4L25 1.5h3.5l-2.7 13h-3.5l1.1-5.6h-4.1l-1.2 5.6h-3.4M37.7 4.4c-.7-.3-1.6-.6-2.9-.6-1.4 0-2.5.2-2.5 1.3 0 1.8 5.1 1.2 5.1 5.1 0 3.6-3.3 4.5-6.4 4.5-1.3 0-2.9-.3-4-.7l.8-2.7c.7.4 2.1.7 3.2.7s2.8-.2 2.8-1.5c0-2.1-5.1-1.3-5.1-5 0-3.4 2.9-4.4 5.8-4.4 1.6 0 3.1.2 4 .6"></path>
Expand Down
3 changes: 2 additions & 1 deletion LearningHub.Nhs.WebUI/Views/Shared/_NavPartial.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@

<div class="nhsuk-width-container nhsuk-header__container app-width-container @PreLoginClass()">

<div class="nhsuk-header__logo"><a class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS homepage">
<div class="nhsuk-header__logo">
<a class="nhsuk-header__link nhsuk-header__link--service " href="/" aria-label="NHS Learning Hub homepage">
<svg class="nhsuk-logo" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 40 16" height="40" width="100">
<path class="nhsuk-logo__background" fill="#005eb8" d="M0 0h40v16H0z"></path>
<path class="nhsuk-logo__text" fill="#fff" d="M3.9 1.5h4.4l2.6 9h.1l1.8-9h3.3l-2.8 13H9l-2.7-9h-.1l-1.8 9H1.1M17.3 1.5h3.6l-1 4.9h4L25 1.5h3.5l-2.7 13h-3.5l1.1-5.6h-4.1l-1.2 5.6h-3.4M37.7 4.4c-.7-.3-1.6-.6-2.9-.6-1.4 0-2.5.2-2.5 1.3 0 1.8 5.1 1.2 5.1 5.1 0 3.6-3.3 4.5-6.4 4.5-1.3 0-2.9-.3-4-.7l.8-2.7c.7.4 2.1.7 3.2.7s2.8-.2 2.8-1.5c0-2.1-5.1-1.3-5.1-5 0-3.4 2.9-4.4 5.8-4.4 1.6 0 3.1.2 4 .6"></path>
Expand Down