Skip to content

Conversation

ArunimaGeorge
Copy link
Contributor

@ArunimaGeorge ArunimaGeorge commented Apr 10, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-2959?atlOrigin=eyJpIjoiZTE3ZjU2ZmMxNjQ4NDc2Y2E1NTE1MjNhMGY4NzcxNzMiLCJwIjoiaiJ9

Description

Added links to the existing html for the pdf certificate generation

Screenshots

Before
image
After:
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@ArunimaGeorge ArunimaGeorge merged commit 8639131 into releases/LHScorpius Apr 18, 2024
@ArunimaGeorge ArunimaGeorge deleted the Develop/fixes/TD-2959-LH-Certificate-Hyperlink-doesnt-work-in-the-downloaded-certificate branch April 18, 2024 08:23
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…/TD-2959-LH-Certificate-Hyperlink-doesnt-work-in-the-downloaded-certificate

TD-2959:Added hyperlinks to the existing html for certificate pdf generation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants