Skip to content

TD-2954: Missing logic added #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes into CI
merged 2 commits into from
Apr 15, 2024
Merged

TD-2954: Missing logic added #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f49785
TD-2954: Missing logic added
sarathlal-sarangadharan Apr 15, 2024
c7f27c9
TD-2954: Deployment fail issue fix
sarathlal-sarangadharan Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion WebAPI/LearningHub.Nhs.Database/LearningHub.Nhs.Database.sqlproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,6 @@
<Build Include="Stored Procedures\Activity\GetUserLearningActivities.sql" />
<Build Include="Stored Procedures\Activity\GetUserLearningActivitiesCount.sql" />
<None Include="Scripts\Post-Deploy\Scripts\TD-2929_ActivityStatusUpdates.sql" />
<None Include="Scripts\Post-Deploy\Scripts\TD-4016_Alter_CatalogueNodeVersionTable.sql" />
</ItemGroup>
<ItemGroup>
<None Include="Scripts\Pre-Deploy\Scripts\Card5766_AuthorTableChanges.PreDeployment.sql" />
Expand Down
3 changes: 1 addition & 2 deletions WebAPI/LearningHub.Nhs.Database/Scripts/Post-Deploy/Script.PostDeployment.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,4 @@ UPDATE [resources].[ResourceVersion] SET CertificateEnabled = 0 WHERE VersionSta
:r .\Scripts\InitialiseDataForEmailTemplates.sql
:r .\Scripts\TD-2929_ActivityStatusUpdates.sql
:r .\Scripts\InitialiseDataForEmailTemplates.sql
:r .\Scripts\AttributeData.sql
:r .\Scripts\TD-4016_Alter_CatalogueNodeVersionTable.sql
:r .\Scripts\AttributeData.sql
8 changes: 0 additions & 8 deletions ...gHub.Nhs.Database/Scripts/Post-Deploy/Scripts/TD-4016_Alter_CatalogueNodeVersionTable.sql
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...PI/LearningHub.Nhs.Database/Stored Procedures/Activity/GetUserLearningActivitiesCount.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ FROM (
AND
(
(SELECT TOP(1)
ISNULL([AssessmentResourceActivity3].[Score],0)
[AssessmentResourceActivity3].[Score]
FROM [activity].[AssessmentResourceActivity] AS [AssessmentResourceActivity3]
WHERE
[AssessmentResourceActivity3].[Deleted] = 0
Expand Down Expand Up @@ -307,7 +307,7 @@ FROM (

AND
(
(SELECT TOP(1) ISNULL([AssessmentResourceActivity5].[Score],0)
(SELECT TOP(1) [AssessmentResourceActivity5].[Score]
FROM [activity].[AssessmentResourceActivity] AS [AssessmentResourceActivity5]
WHERE [AssessmentResourceActivity5].[Deleted] = 0
AND [ResourceActivity].[Id] = [AssessmentResourceActivity5].[ResourceActivityId]) < Cast([AssessResVer].[PassMark] AS DECIMAL(18,2))
Expand Down
2 changes: 1 addition & 1 deletion WebAPI/LearningHub.Nhs.Database/Tables/Hierarchy/CatalogueNodeVersion.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
[CardImageUrl] NVARCHAR (128) NULL,
[BannerUrl] NVARCHAR (128) NULL,
[CertificateUrl] NVARCHAR (128) NULL,
[Description] NVARCHAR (4000) NOT NULL,
[Description] NVARCHAR (MAX) NOT NULL,
[OwnerName] NVARCHAR (250) NULL,
[OwnerEmailAddress] NVARCHAR (250) NULL,
[Notes] NVARCHAR (MAX) NULL,
Expand Down