Skip to content

Conversation

@AnjuJose011
Copy link
Contributor

JIRA link

TD-###

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

akdalin-hee and others added 30 commits January 30, 2024 17:59
…r-details-accessibility-fix

Correct autocomplete references in alignment to HTML best practices
…marks-accessibility-fix

Fix accessibility issues in My Bookmarks section
…-result-accessibility-fix

Fix learner search page and search results accessibility issues
…ogue-pages-accessibility-fix

Fix learner catalogue pages accessibility issues
…H/TD-3546-Azure-Log-Threads-are-mixing-synchronous-code-with-asynchronous-code

TD-3546: Azure Log -Threads are mixing synchronous code with asynchro…
…/LH-TD-3541-Zip-file-can-be-marked-as-SCORM-outdated-feature

TD-3541- Zip file can be marked as SCORM outdated feature
…earning-resources-accessibility-issues

Fix learning resources accessibility issues
…TD-3676-UpdateOpenAPIBrandingAndLinks

TD-3676 Updates branding and links in the OpenAPI project to NHS England
sarathlal-sarangadharan and others added 28 commits April 12, 2024 09:02
…res/TD-4016-Remove-character-limit-from-catalogue-description-script

TD-4016: Deployment issue fix
…res/TD-4016-Remove-character-limit-from-catalogue-description-BuildFail

TD-4016:Build fail fix
…res/TD-4016-Remove-character-limit-from-catalogue-description-BuildFailFix

TD-4016:Build fail fix
…res/TD-2954-My-Learning-Page-Improvements-in-Performance-BugFix

TD-2954: Filter fix
…res/TD-2954-My-Learning-Page-Improvements-in-Performance-Missing-SP

TD-2954: Missing logic added
…res/TD-3285-feature_flag_functionality_for_ams_contents

TD-3285, vue cache storing the feature flag inconsistently, update the way its populating now
…/TD-3023-fix

TD-3023 fix for unpublished and deleted draft
…/TD-3023-fix

TD-3023 limit the removal of output content to scorm and html resource
…63-corrections

Merge-Apply additional corrections for TD3162 and TD3163
…/LH-TD-3955-Certificate-not-unlocking-for-user

TD-3741 - LMS server issue related to active content cache is null.
… removed code to fix the issue and implemented same logic in newly created stored procedures.
…/TD-4047-My-Learning-page-elearning-with-Assessment-displays-the-learning-record-twice-based-upon-the-assessment-result

TD-4047: Duplicate records appearing in Mylearning page. Brought back removed code to fix the issue and implemented same logic in newly created stored procedures.
…/LH-To_correct_the_naming_convention

Corrected the naming convention for uniformity
…/LH-TD-3955_Reverting_the_Changes

TD-3955 : Reverted the changes related to the Scorm commit
@AnjuJose011 AnjuJose011 merged commit 82d2c32 into releases/LHScorpius Apr 17, 2024
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants