Skip to content

Conversation

@Swapnamol
Copy link
Contributor

@Swapnamol Swapnamol commented May 13, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4115

Description

My accessed learning’ tray, showing this completed (passed) informal assessment not showing on the ‘Certificates’ section - fixed

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OR ((r.ResourceTypeId = 11 AND arv.AssessmentType = 2) AND ((ara.Id IS NOT NULL AND ara.score < arv.PassMark) OR ra.ActivityStatusId IN (7)))

Here, this condition may fail if passMark is null. Better to include ISNULL( arv.PassMark,0) .
@Swapnamol

@Swapnamol Swapnamol merged commit 61eabf2 into RC May 13, 2024
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…/LH-TD-4115-My_accessed_Tray_Issues_Status_fixes

TD-4115- My accessed learning tray issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants