Skip to content

Conversation

@sarathlal-sarangadharan
Copy link
Contributor

@sarathlal-sarangadharan sarathlal-sarangadharan commented May 31, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4203

Description

Considering only active users IN Catalogue access request

Screenshots

Before code change:
image

After code change:
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@sarathlal-sarangadharan sarathlal-sarangadharan merged commit d34a73f into releases/LHScorpius May 31, 2024
@sarathlal-sarangadharan sarathlal-sarangadharan deleted the Develop/Fixes/TD-4023-Catalogue-access-request-stuck-pending branch May 31, 2024 11:54
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…/TD-4023-Catalogue-access-request-stuck-pending

TD-4023: Considering only active users IN Catalogue access request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants