Develop/feature/td 2895 2 activity status

[Phil-NHS]

JIRA link
TD-2895

Description

• resource endpoints pass currentUserId from OAuth or pass it as null from the ApiKey to their methods
• open API endpoints return activity summary data when userId is not null
• Use new helper class from LH models to provide friendly name for activity description
• Updated open API models to include major version id

Tests added for
resourceControllerTests

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors
• Written appropriate unit tests for the changes, including:
  • accessibility tests for new views
  • tests for new controller methods
  • tests for new or modified API endpoints
• Manually tested my work with and without JavaScript
• Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
• Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

[Phil-NHS]

Anyone seen the typescript issue before is there an easy fix :) I've had some issues with the packages since set up that I tried to resolve the issue previously if its the same one by running yarn, and node update, cleaning and rebuilding - fixed by virgo fix

[AnjuJose011]

can you please let me know why we have a hard code value for authentication type?

[Phil-NHS]

can you please let me know why we have a hard code value for authentication type?

Because we only have userId in this authentificationtype

[AnjuJose011]

is this changes are related to the scope of this ticket?

[Phil-NHS]

is this changes are related to the scope of this ticket?

Yes. For every major version we return activity (not just the most recent like the rest of the data from the end point), not just the version looked at. The data is provided through a stored procedure. The reason for this is that we want to know if the user has previously completed a resource even if it is a previous version for example. So the logic takes the most important activityStatus per version per resource