Skip to content

Conversation

OluwatobiAwe
Copy link
Contributor

@OluwatobiAwe OluwatobiAwe commented Jul 25, 2024

JIRA link

TD-4417

Description

LH model update. There was a character count validation on textbox blocks which upon failure, made resource publish to fail. This validation has now been removed and user can allowed to input as much text as needed. The code change was in the LH nuget package.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@OluwatobiAwe OluwatobiAwe merged commit 874879c into RC Jul 25, 2024
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants