Skip to content

Conversation

@AnjuJose011
Copy link
Contributor

@AnjuJose011 AnjuJose011 commented Aug 1, 2024

JIRA link

TD-4388

Description

Assessment resource settings need a required field marker

Screenshots

image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@AnjuJose011 AnjuJose011 requested a review from Swapnamol August 1, 2024 08:27
@AnjuJose011 AnjuJose011 merged commit 0a89387 into releases/LHVirgo Aug 1, 2024
@kevwhitt-hee kevwhitt-hee changed the title TD-4388-Assessment resource settings need a required field marker TD-4388 Assessment resource settings need a required field marker Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants