Skip to content

Conversation

@Phil-NHS
Copy link
Contributor

@Phil-NHS Phil-NHS commented Aug 6, 2024

JIRA link

_TD-3678

Minor change to swagger version


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • [ x] Run the formatter and made sure there are no IDE errors
  • [ x] Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • [ x] Manually tested my work with and without JavaScript
  • [ x] Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • [ x] Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • [ x] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • [ x] Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

@Phil-NHS Phil-NHS requested a review from AnjuJose011 August 7, 2024 08:35
@Phil-NHS Phil-NHS self-assigned this Aug 7, 2024
@Phil-NHS
Copy link
Contributor Author

Phil-NHS commented Aug 7, 2024

@AnjuJose011 have added the bookmark fix. please could you have a check then if your still happy I'll merge :)

@AnjuJose011
Copy link
Contributor

@Phil-NHS please go ahead and merge the changes.

@Phil-NHS Phil-NHS merged commit a0335c5 into CI Aug 7, 2024
AnjuJose011 pushed a commit that referenced this pull request Aug 19, 2024
…re/TD-3678-swagger-version-json-update

Swagger file was missing certificates endpoint
AnjuJose011 pushed a commit that referenced this pull request Sep 18, 2024
…re/TD-3678-swagger-version-json-update

Swagger file was missing certificates endpoint
AnjuJose011 pushed a commit that referenced this pull request Sep 18, 2024
…re/TD-3678-swagger-version-json-update

Swagger file was missing certificates endpoint
AnjuJose011 pushed a commit that referenced this pull request Sep 18, 2024
…re/TD-3678-swagger-version-json-update

Swagger file was missing certificates endpoint
AnjuJose011 pushed a commit that referenced this pull request Sep 18, 2024
…re/TD-3678-swagger-version-json-update

Swagger file was missing certificates endpoint
ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…re/TD-3678-swagger-version-json-update

Swagger file was missing certificates endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants