Skip to content

TD-4009: Google Tag Manager tracking for all Non Prod Environments [ … #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge RC changes into CI
merged 1 commit into from
Aug 9, 2024
Merged

TD-4009: Google Tag Manager tracking for all Non Prod Environments [ … #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LearningHub.Nhs.WebUI/Views/Shared/_GoogleTagManagerNoScriptPartial.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@inject LearningHub.Nhs.WebUI.Configuration.Settings settings
@inject Microsoft.AspNetCore.Hosting.IWebHostEnvironment hostingEnv
@if (settings.GoogleTagManagerEnabled && hostingEnv.EnvironmentName == "Production")
@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
@if (settings.GoogleTagManagerEnabled && @Configuration["Environment"] == "Production")
{
<!-- Google Tag Manager (noscript) -->
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=@settings.GoogleTagManagerContainerId"
Expand Down
4 changes: 2 additions & 2 deletions LearningHub.Nhs.WebUI/Views/Shared/_GoogleTagManagerPartial.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
@inject LearningHub.Nhs.WebUI.Configuration.Settings settings
@inject Microsoft.AspNetCore.Hosting.IWebHostEnvironment hostingEnv
@inject Microsoft.Extensions.Configuration.IConfiguration Configuration
@{
var detectCookieStatusBeforePageLoad = (string)TempData["ObtainUserConsentToTrackPriorToPageLoad"]; // Need to capture cookie status before page load to avoid inconsistencies.
}

@if (detectCookieStatusBeforePageLoad == "true" && settings.GoogleTagManagerEnabled && hostingEnv.EnvironmentName == "Production") // [BY] When the user consent for first time load the follolwing JS. To avoid inconsistencies a temp varaible has been set when the user consent cookie choice
@if (detectCookieStatusBeforePageLoad == "true" && settings.GoogleTagManagerEnabled && @Configuration["Environment"] == "Production") // [BY] When the user consent for first time load the follolwing JS. To avoid inconsistencies a temp varaible has been set when the user consent cookie choice
{
<!-- Google Tag Manager -->
<script>
Expand Down