Skip to content

Conversation

@sarathlal-sarangadharan
Copy link
Contributor

@sarathlal-sarangadharan sarathlal-sarangadharan commented Aug 21, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4394

Description

Publishing catalogues needs to update referencing catalogues

Screenshots

Scenarios checked:

  1. Created 2 Catalogues Ext1 and Ext2
    image

  2. Created a new folder under Ext2
    image

  3. Added external reference of 10-Level1 (Ext1) to Ext2
    image

  4. After publish created new folder 11-Level2 under 10-Level1
    image

  5. Renamed child folder 11-Level2 to Level2Rename which reflected under Ext1 too.
    image

  6. Added again new folder under 10-Level1 (Ext2) which reflects under Ext1 too.
    image

  7. Moved up folders which also reflected in Ext1
    image
    image

  8. Contributed a new Resource to Ext2 > 10- Level1 which reflected in Ext1 > 100 -Level1 > 10 -Level1
    image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link

@DRJTechnology DRJTechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further invistigation and conversations the following scenario is not handled by the change.

If a section of content is referenced from one catalogue to another, the referenced content is correctly showing in the target catalogue in both the AdminUI and the WebUI.
After publishing, if a resource in the source catalogue in moved to a different position in the folder structure, the target catalogue (after publish) shows the resource correctly in the AdminUI but the WebUI doesn’t show the resource (in either it’s original position or it’s new position).

Investigation of the data reveals that the ResourceReference records are not updated correctly. New ResourceReference records should be created for the resource’s new position in the structure with an OriginalResourceReferenceId set to the initial OriginalResourceReferenceId. The original ResourceReference record should be marked aas deleted.

Note: In these scenarios ResourceReference records are created by the stored procedures HierarchyEditMoveResource & HierarchyEditMoveNode

Copy link

@DRJTechnology DRJTechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra scenario handled by work other ticket

ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…/TD-4394-Publishing-catalogues-needs-to-update-referencing-catalogues

TD-4394: Publishing catalogues needs to update referencing catalogues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants