Skip to content

Conversation

@AnjuJose011
Copy link
Contributor

JIRA link

TD-###

Description

Describe what has changed and how that will affect the app. If relevant, add references to the resources you used. Use this as your opportunity to highlight anything odd and give people context around particular decisions.

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

akdalin-hee and others added 30 commits May 31, 2024 11:38
…cedLearning/LearningHub.Nhs.WebUI into Develop/Feature/TD-3678-Implement-OpenAPI-endpoints-to-retrieve-My-Accessed-Learning-resources
AnjuJose011 and others added 29 commits October 29, 2024 09:13
TD-4197-DIG1405: Button text is not descriptive of purpose
…/TD-4992-UpdatePRTemplate

TD-4992 Update PR template
…/TD-4081-DIG306-Labels-for-form-fields-are-missing

TD-4081:DIG306: Labels for form fields are missing
…/TD-4072-DIG201-Content-has-heading-markup,-but-is-not-a-heading

TD-4072: DIG201 Content has heading markup, but is not a heading issue fixed
…/TD-4080-DIG302_Placeholder-text-cannot-be-used-to-label-forms

TD-4080: DIG302: Placeholder text cannot be used to label forms
…/TD-4079-DIG301-Form-fields-are-not-associated-with-text-labels

TD:4079: DIG301: Form fields are not associated with text labels
…/TD-4079-DIG301-Form-fields-are-not-associated-with-text-labels

TD-4079: Form elements should have an id attribute
Merge RC changes to release -V1.0.0
…/TD-4194-DIG1302-Focus-order-is-incorrect-or-illogical

TD-4194:DIG1302: Focus order is incorrect or illogical
…/TD-4070-DIG002-Decorative-images-should-have-an-empty-alt-attribute

TD-4070: Removed text from alt attribute for decorative images.
…res/TD-4824-Implement-click-logs-for-autosuggestion-in-Learning-Hub

TD-4824: Implemented click logs for Auto suggestions.
@AnjuJose011 AnjuJose011 merged commit a9c85bd into RC Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants