Skip to content

cicd changes #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Feat button for cicd testing
merged 6 commits into from
May 27, 2025
Merged

cicd changes #53

merged 6 commits into from
May 27, 2025

Conversation

@Phil-NHS
Copy link
Collaborator

PR Template

TODO:

Test it here too
https://technologyenhancedlearning.github.io/GitPageBlazorWASM-TestGHPage/
check version matches branch name and pullrequest release

  • maybe a rule that any introduced css for example if bringing in an enum. needs to be refactored to nhse-tel? so tel-nhse is source of truth on all things css

TODO: About

  • SO FAR no js controllers are not going to be covered in testing in the package it will be done by how used in LH
    But in future we could simulate them with just an api with stock response or find a programatic way, or build a hosted environment.
    The gh-page are pure wasm so not supported for nojs

  • brave check no js (Locally not on wasm static test page)

TODO: This is just replicating LH for now ... ideas

  • Link to replicated component
  • Link design confluence if coming from design
  • Tick box for JS
  • If testers find an issue create an automated test of what they did, even potentially with playright record test functionality
  • something about is there a linked lh branch using the change

JIRA link

TD-####

Description

Describe what has changed and how that will affect the app. If relevant, add links to any sources/documentation you used. Highlight anything unusual and give people context around particular decisions.

Screenshots

Paste screenshots for all views created or changed: mobile, tablet and desktop, wave analyser showing no errors.

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

Phil-NHS and others added 6 commits May 27, 2025 12:08
@Phil-NHS
Merge pull request #51 from TechnologyEnhancedLearning/feat-button-fo…
0a7a3c1 
…r-cicd-testing

Feat button for cicd testing
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
ecc1dff 
# [1.1.0](v1.0.4...v1.1.0) (2025-05-27)

### Features

* **button:** add to msbuild with params ([36e0f1a](36e0f1a))
* **button:** adding to layout ([05bb41d](05bb41d))
* **button:** appsettings production ([a1cc496](a1cc496))
* **button:** artifact by name ([ba7e990](ba7e990))
* **button:** avoiding ignores ([5ee0f4a](5ee0f4a))
* **button:** bad commit squash ([db2829a](db2829a))
* **button:** baseurl encode appsettings next ([07f4abf](07f4abf))
* **button:** build solution to trigger node ([f913e27](f913e27))
* **button:** build type ([a0b9e9a](a0b9e9a))
* **button:** button with logger squash me ([64c6616](64c6616))
* **button:** caps ([8890eda](8890eda))
* **button:** centralise node ([7eaed95](7eaed95))
* **button:** cicd ([bcce28f](bcce28f))
* **button:** cicd ([131bbeb](131bbeb))
* **button:** cicd appsettings ([c90f8c9](c90f8c9))
* **button:** cicd for pr checks ([0d3d3b4](0d3d3b4))
* **button:** cicd no id on job ([66a634e](66a634e))
* **button:** cicd release script ([4a7ce57](4a7ce57))
* **button:** cicd test ([060fab2](060fab2))
* **button:** cicd tidy up ([21012a5](21012a5))
* **button:** cicds ([eedcc25](eedcc25))
* **button:** combining test e2e unit coverage threshold report ([efbdb06](efbdb06))
* **button:** comments out of e2e json ([d03697d](d03697d))
* **button:** continue on error ([f8c4a03](f8c4a03))
* **button:** coverlet ([b7d2416](b7d2416))
* **button:** data not exposed ([de2e4c4](de2e4c4))
* **button:** debug ([c0b3dd0](c0b3dd0))
* **button:** debug ([57d5c75](57d5c75))
* **button:** debug ([75bbce2](75bbce2))
* **button:** debug routes ([8ee1840](8ee1840))
* **button:** declared higher ([1c88c7e](1c88c7e))
* **button:** deploy to report site ([49bbb83](49bbb83))
* **button:** disabled thresholds ([252ac90](252ac90))
* **button:** doesnt run in triggered ([eb65a6d](eb65a6d))
* **button:** dont test against prod appsetting yet ([66b1292](66b1292))
* **button:** drop slash ([28c6bc4](28c6bc4))
* **button:** e2e cicd ([f83fa0d](f83fa0d))
* **button:** explicity headless setting defaulting to false ([66f0416](66f0416))
* **button:** fail check ([e56e555](e56e555))
* **button:** go ([54e9c57](54e9c57))
* **button:** gogo ([4a7e76e](4a7e76e))
* **button:** gogo ([dc449de](dc449de))
* **button:** having a solution release build as a check so including appsettings ([2595414](2595414))
* **button:** home ([a7c2227](a7c2227))
* **button:** htmlhtml typo ([f32f96a](f32f96a))
* **button:** in the meantime ([3e54b2f](3e54b2f))
* **button:** in trigger yml ([5064e1c](5064e1c))
* **button:** is it event set ([f49bed7](f49bed7))
* **button:** just declare accept extra build ([fc63f71](fc63f71))
* **button:** just home link ([07ce5f5](07ce5f5))
* **button:** layout fiddling ([bfef5f8](bfef5f8))
* **button:** layouts ([6d6d64f](6d6d64f))
* **button:** little change ([022d3e1](022d3e1))
* **button:** loglevel before testing changes ([aff78a0](aff78a0))
* **button:** luck ([af7eea3](af7eea3))
* **button:** missing package ([5f879b5](5f879b5))
* **button:** missing versions ([6c850db](6c850db))
* **button:** need to centralise css creation and target showcase ([54571ff](54571ff))
* **button:** nicer breaking ([1d591e0](1d591e0))
* **button:** node changes this time ([df526bb](df526bb))
* **button:** none verbose ([3bc7897](3bc7897))
* **button:** not getting appsettings cicd ([75e414b](75e414b))
* **button:** not picking up devyml change ([07eca52](07eca52))
* **button:** not worry about folder exclude atm ([552dc73](552dc73))
* **button:** npm at solution level ([5b910fc](5b910fc))
* **button:** odd ([5b182b2](5b182b2))
* **button:** p go ([b9e2de8](b9e2de8))
* **button:** package version dev ([bf6f327](bf6f327))
* **button:** passing secret to reuseable-ci ([232af52](232af52))
* **button:** previous path loc ([871d1cb](871d1cb))
* **button:** propograte changes ([8588a07](8588a07))
* **button:** props ([5bd2e0e](5bd2e0e))
* **button:** pseudo code ([81a03e3](81a03e3))
* **button:** push while listen ([2868f4c](2868f4c))
* **button:** qqqq tidying ([d1480dd](d1480dd))
* **button:** quick check ([50e40c6](50e40c6))
* **button:** readme ([73dd526](73dd526))
* **button:** readme ([ae3110e](ae3110e))
* **button:** really ([938e8ce](938e8ce))
* **button:** refactor ([fd58121](fd58121))
* **button:** Refactoring and nhsukfrontend version ([4e65815](4e65815))
* **button:** relative routes in csproj ([71d6b23](71d6b23))
* **button:** remove coverlet.collector and exclude some coverage ([56939ea](56939ea))
* **button:** resusable ci ([4c90c6a](4c90c6a))
* **button:** route fix for appsettings ([67406f8](67406f8))
* **button:** routing for ci ([296da4d](296da4d))
* **button:** runsetting go while local test ([66050b3](66050b3))
* **button:** scattershot ([4aa11aa](4aa11aa))
* **button:** secret accessible ([02e66b8](02e66b8))
* **button:** secrets declared differently in triggered ([cc18ec0](cc18ec0))
* **button:** seeing it ([c723135](c723135))
* **button:** seems bad ([4b27e92](4b27e92))
* **button:** semi not comma ([aeafb9f](aeafb9f))
* **button:** shouldnt need it ([57208f4](57208f4))
* **button:** spam cicd ([c852a5c](c852a5c))
* **button:** speach marks ([cf1dc99](cf1dc99))
* **button:** squash ([8b41944](8b41944))
* **button:** squash later ([1fe1a3a](1fe1a3a))
* **button:** squash later ([ee875ce](ee875ce))
* **button:** squashing ([443e8d9](443e8d9))
* **button:** stop e2e building just needs to test ([838e3dd](838e3dd))
* **button:** strange undetectable yml issue maybe ([7c96522](7c96522))
* **button:** test ([782d223](782d223))
* **button:** test cicd ([4ba0d06](4ba0d06))
* **button:** test route ([b101e0d](b101e0d))
* **button:** test yml ([c8f5772](c8f5772))
* **button:** threshold ([2d7c7f5](2d7c7f5))
* **button:** threshold ([8e6e2bd](8e6e2bd))
* **button:** token ([9da3263](9da3263))
* **button:** token ([ad32f69](ad32f69))
* **button:** try it ([067e269](067e269))
* **button:** try using just built ([08fcb2b](08fcb2b))
* **button:** use package ref ([91df5c9](91df5c9))
* **button:** very low threshold till tests ready ([d81f0d7](d81f0d7))
* **button:** what sticks ([7b163dc](7b163dc))
* **button:** works locally ([9806216](9806216))
* **button:** xmysummary ci-reuseably yml ([643add3](643add3))
* **button:** yml ([45d8567](45d8567))
* **button:** yml check ([ef73d87](ef73d87))
* **button:** yml err ([574ddf3](574ddf3))
* **button:** yml fix ([154941b](154941b))
* **refactor:** direct build props ([ae832d5](ae832d5))
@Phil-NHS
feat(cicd): Update release.yml
fc0e758
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
8e6a826 
# [1.2.0](v1.1.0...v1.2.0) (2025-05-27)

### Features

* **cicd:** Update release.yml ([fc0e758](fc0e758))
@Phil-NHS
feat(cicd): Update release.yml pckage ref
41ebcda
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
2555393 
# [1.3.0](v1.2.0...v1.3.0) (2025-05-27)

### Features

* **cicd:** Update release.yml pckage ref ([41ebcda](41ebcda))
@Phil-NHS Phil-NHS merged commit c252c7f into feat-button-for-cicd-testing May 27, 2025
1 check passed
@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.4.0-feat-button-for-cicd-testing.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kevwhitt-hee
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released on @feat-button-for-cicd-testing released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Phil-NHS @kevwhitt-hee @semantic-release-bot