-
Notifications
You must be signed in to change notification settings - Fork 7
ANDROID-16201 - Update API 34 and some components such AGP and Kotlin versions #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update AGP 7.4 --> 8.11 - compileSdk and targetSdk 31 --> 34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following ticket is created to do corresponding migration to "shared-workflows": https://jira.tid.es/browse/ANDROID-16907
build.gradle
Outdated
id 'org.jetbrains.kotlin.android' version '1.6.21' apply false | ||
id 'com.android.application' version '8.11.2' apply false | ||
id 'com.android.library' version '8.11.2' apply false | ||
id 'org.jetbrains.kotlin.android' version '2.2.20' apply false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would update to Kotlin 2.1 as we have in the rest of the apps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied changes here: bdb1c13
To last stable 2.1.X Kotlin version: https://kotlinlang.org/docs/whatsnew2120.html
# resources declared in the library itself and none from the library's dependencies, | ||
# thereby reducing the size of the R class for that library | ||
android.nonTransitiveRClass=true | ||
android.nonFinalResIds=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the Android Studio AGP assistant update to do this task quicker and it added this line.
Checking the documentation:
https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes?hl=es-419#default-changes
This line disables the new generation of non-final resources introduced in AGP, causing R ID's to return to final. It's usually added automatically when you migrate an old project to maintain compatibility, although it's recommended to gradually remove this dependency and leave it as true (or simply not declare it, since the current default is true).
If you consider necessary I would remove this line. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, no problem, we can maintain it
I would generate a snapshot and test it with android-messenger repo to be sure that it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Tested this snapshot "0.2.0-SNAPSHOT" version: |
ποΈ Jira ticket
ANDROID-16201
π₯ What's the goal?
Update the current Android API level 31 -> 34
π§ How do we do it?
The apply this update is necessary to apply next upgrades:
compileSdk
andtargetSdk
31 --> 34test.yml
file to fit corresponding workflow to use Java 17β Documentation changes?
π§ͺ How can I test this?