-
Notifications
You must be signed in to change notification settings - Fork 7
ANDROID-16201 - Update API 34 and some components such AGP and Kotlin versions #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b76098d
eeef97d
6592d43
1dc44a3
8eb724c
b335486
bdb1c13
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
### :tickets: Jira ticket | ||
[ANDROID-XXXX](https://jira.tid.es/browse/ANDROID-XXXX) | ||
|
||
### :goal_net: What's the goal? | ||
_Provide a description of the overall goal. The description in the Jira ticket may help._ | ||
|
||
### :construction: How do we do it? | ||
_Provide a description of the implementation. A list of steps would be ideal._ | ||
* _Step 1_ | ||
* _Step 2_ | ||
* _Step 3_ | ||
|
||
### :white_check_mark: Documentation changes? | ||
- [ ] No docs to update nor create | ||
|
||
### :test_tube: How can I test this? | ||
_If it cannot be tested explain why._ | ||
- [ ] ... |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,3 +21,4 @@ kotlin.code.style=official | |
# resources declared in the library itself and none from the library's dependencies, | ||
# thereby reducing the size of the R class for that library | ||
android.nonTransitiveRClass=true | ||
android.nonFinalResIds=false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I followed the Android Studio AGP assistant update to do this task quicker and it added this line. This line disables the new generation of non-final resources introduced in AGP, causing R ID's to return to final. It's usually added automatically when you migrate an old project to maintain compatibility, although it's recommended to gradually remove this dependency and leave it as true (or simply not declare it, since the current default is true). If you consider necessary I would remove this line. WDYT? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, no problem, we can maintain it |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
#Wed Aug 03 11:27:29 CEST 2022 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip | ||
distributionPath=wrapper/dists | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip | ||
networkTimeout=10000 | ||
validateDistributionUrl=true | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following ticket is created to do corresponding migration to "shared-workflows": https://jira.tid.es/browse/ANDROID-16907