-
Notifications
You must be signed in to change notification settings - Fork 6
Liquidator redesign: liquidation, rebalancing, swap implementation and testing. #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
royalf00l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some minor details.
Ideally there would be some more test coverage on the liquidator as well since it's a backend service.
Also worth noting that the first next step is supporting deposits into intents and withdraws from intents. https://docs.near-intents.org/near-intents/market-makers/passive-deposit-withdrawal-service. This is necessary for liquidators who don't keep stables always deposited on Intents or want to liquidate collateral on other venues
Installed near-sandbox into /home/runner/work/contracts/contracts/target/debug/build/near-sandbox-utils-2ad3b5a56a37a3e2/out/.near/near-sandbox-2.8.0/near-sandbox Gas ReportSnapshot Limits
Estimated snapshot limit: 9635
Estimated snapshot limit: 11505 Action Gas Descriptors
|
peer2f00l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small things that can be cleaned later. LGTM.
petarvujovic98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new abstractions to balance and inventory management.
In general looks good, just a few nits here and there, but not blockers
TODO next:
This change is