Created script to delete grafana dashboards #574

anmolsachan · 2018-09-20T13:53:55Z

tendrl-bug-id: #575
bugzilla: 1631260
Signed-off-by: Anmol Sachan anmol13694@gmail.com

anmolsachan · 2018-09-20T13:55:49Z

@nthomas-redhat @shtripat @GowthamShanmugam Please review.

shtripat · 2018-09-20T14:15:13Z

upgrades/delete_dashboards.py

+
+    username = raw_input("Please enter the grafana admin_username "
+                         "default-[%s]: " % default_user) or default_user
+    password = raw_input("Please enter the grafana admin_password default"


Would you be able to hide this while user enters the password? That would be better.

@shtripat yes, it can be hidden, I thought of showing it so that user can cross-verify the default vs what he knows. Should I hide it ?

I am fine with any approach as this is just a tool, but personally I feel it should be hidden. Anyway if wrong password passed, later stage it would fail with error.

@shtripat Please review, I added command line args
It will work like: python delete_dashboards.py --username=admin --password=pass

If the args are not supplied, it will take from grafana.ini

shtripat · 2018-09-20T14:15:42Z

upgrades/delete_dashboards.py

+    print "\n Clearing grafana dashboards \n"
+    delete_dashboards(server_ip=default_ip, user=username,
+                      password=password)
+    print "\n Complete -- Please start tendrl-monitoring-integration service"


And carbon-cache service?

@shtripat Rest of the steps will be supplied with the documentation.

But in command line as well we should to restart tendrl-monitoring-integration and carbon-cache and order should be start carbon-cache and then tendrl-monitoring-integration I feel.

@nthomas-redhat what you say?

Otherwise code look good to me.

@shtripat We will not stop carbon cache as there is no interference with it. Should we stop carbon-cache ?

If no interference then its fine

codecov · 2018-09-20T16:51:31Z

Codecov Report

❗ No coverage uploaded for pull request base (master@817d977). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master    #574   +/-   ##
========================================
  Coverage          ?   44.1%           
========================================
  Files             ?      41           
  Lines             ?    2351           
  Branches          ?     352           
========================================
  Hits              ?    1037           
  Misses            ?    1261           
  Partials          ?      53

Impacted Files	Coverage Δ
...nitoring_integration/upgrades/delete_dashboards.py	`0% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817d977...50427c4. Read the comment docs.

shtripat

LGTM

cybernth · 2018-09-21T05:31:45Z

@anmolsachan , i am not seeing the spec file changes here?
This file to be placed in use/local/bin/tendrl
Also is it a good idea to integrate the execution of script integrated with rpm spec itself? Or tendrl-ansible?
@shtripat , @TimothyAsirJeyasing , @mbukatov ?

cybernth · 2018-09-21T05:56:20Z

Also is it a good idea to integrate the execution of script integrated with rpm spec itself?
@shtripat , @TimothyAsirJeyasing ?

For now let's go with the manual route; later we can think of get that integrated with ansible or rpm scripts itself. @anmolsachan , please raise an issue to track

anmolsachan · 2018-09-21T09:04:22Z

@nthomas-redhat I have made changes according to your suggestion. The script is located at /usr/bin/tendrl-monitoring-integration-upgrade and can be run as " /usr/bin/tendrl-monitoring-integration-upgrade --username=username --password= password". It gets installed with the rpm. Verified.

shtripat

LGTM
@nthomas-redhat please check once and do the needful.

cybernth · 2018-09-21T09:21:37Z

@nthomas-redhat I have made changes according to your suggestion. The script is located at /usr/bin/tendrl-monitoring-integration-upgrade and can be run as " /usr/bin/tendrl-monitoring-integration-upgrade --username=username --password= password". It gets installed with the rpm. Verified.

Couple of questions:

who places the file into usr/local/bin? I don't see any code doing that part.
What happens if its a fresh install and not an upgrade?
What happens if the grafana server is not running?

shtripat · 2018-09-21T09:28:05Z

who places the file into usr/local/bin? I don't see any code doing that part.

Its setup.py job

What happens if its a fresh install and not an upgrade?

This tool gets deployed but no need to use it

What happens if the grafana server is not running?

If we try to execute the tool it will fail

@anmolbabu correct me if wrong here.

tendrl-bug-id: Tendrl#575 bugzilla: 1631260 Signed-off-by: Anmol Sachan <anmol13694@gmail.com> Making delete_dashboards.py as an executable

anmolsachan requested a review from a team as a code owner September 20, 2018 13:53

shtripat reviewed Sep 20, 2018

View reviewed changes

anmolsachan force-pushed the B1_update branch from 5387ce6 to 4c4e217 Compare September 20, 2018 17:13

shtripat reviewed Sep 21, 2018

View reviewed changes

anmolsachan force-pushed the B1_update branch from 62bb3ed to 5949f92 Compare September 21, 2018 08:43

shtripat reviewed Sep 21, 2018

View reviewed changes

created script to delete grafana dashboards

50427c4

tendrl-bug-id: Tendrl#575 bugzilla: 1631260 Signed-off-by: Anmol Sachan <anmol13694@gmail.com> Making delete_dashboards.py as an executable

anmolsachan force-pushed the B1_update branch from 5949f92 to 50427c4 Compare September 21, 2018 09:36

cybernth approved these changes Sep 21, 2018

View reviewed changes

cybernth merged commit ecf7299 into Tendrl:master Sep 21, 2018

Created script to delete grafana dashboards #574

Created script to delete grafana dashboards #574

Uh oh!

Conversation

anmolsachan commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anmolsachan commented Sep 20, 2018

Uh oh!

shtripat Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

anmolsachan Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shtripat Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

anmolsachan Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shtripat Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

anmolsachan Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

shtripat Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

anmolsachan Sep 20, 2018

Choose a reason for hiding this comment

Uh oh!

shtripat Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shtripat left a comment

Choose a reason for hiding this comment

Uh oh!

cybernth commented Sep 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cybernth commented Sep 21, 2018

Uh oh!

anmolsachan commented Sep 21, 2018

Uh oh!

shtripat left a comment

Choose a reason for hiding this comment

Uh oh!

cybernth commented Sep 21, 2018

Uh oh!

shtripat commented Sep 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anmolsachan commented Sep 20, 2018 •

edited

Loading

anmolsachan Sep 20, 2018 •

edited

Loading

anmolsachan Sep 20, 2018 •

edited

Loading

shtripat Sep 21, 2018 •

edited

Loading

codecov bot commented Sep 20, 2018 •

edited

Loading

cybernth commented Sep 21, 2018 •

edited

Loading