Skip to content

feat: Replace SurfaceHeightFacet with ElevationFacet #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2020
Merged

feat: Replace SurfaceHeightFacet with ElevationFacet #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/terasology/tutorial/minimalenginedemo/world/BuilderWorldRasterizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.terasology.world.chunks.CoreChunk;
import org.terasology.world.generation.Region;
import org.terasology.world.generation.WorldRasterizer;
import org.terasology.world.generation.facets.SurfaceHeightFacet;
import org.terasology.world.generation.facets.ElevationFacet;

public class BuilderWorldRasterizer implements WorldRasterizer {

Expand All @@ -38,9 +38,9 @@ public void initialize() {

@Override
public void generateChunk(CoreChunk chunk, Region chunkRegion) {
SurfaceHeightFacet surfaceHeightFacet = chunkRegion.getFacet(SurfaceHeightFacet.class);
ElevationFacet elevationFacet = chunkRegion.getFacet(ElevationFacet.class);
for (Vector3i position : chunkRegion.getRegion()) {
float surfaceHeight = surfaceHeightFacet.getWorld(position.x, position.z);
float surfaceHeight = elevationFacet.getWorld(position.x, position.z);
if (position.y < surfaceHeight - 1) {
chunk.setBlock(ChunkMath.calcRelativeBlockPos(position), dirt);
} else if (position.y < surfaceHeight) {
Expand Down
10 changes: 5 additions & 5 deletions src/main/java/org/terasology/tutorial/minimalenginedemo/world/SurfaceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
import org.terasology.world.generation.FacetProvider;
import org.terasology.world.generation.GeneratingRegion;
import org.terasology.world.generation.Produces;
import org.terasology.world.generation.facets.SurfaceHeightFacet;
import org.terasology.world.generation.facets.ElevationFacet;

@Produces(SurfaceHeightFacet.class)
@Produces(ElevationFacet.class)
public class SurfaceProvider implements FacetProvider {

private Noise surfaceNoise;
Expand All @@ -40,8 +40,8 @@ public void setSeed(long seed) {
@Override
public void process(GeneratingRegion region) {
// Create our surface height facet (we will get into borders later)
Border3D border = region.getBorderForFacet(SurfaceHeightFacet.class);
SurfaceHeightFacet facet = new SurfaceHeightFacet(region.getRegion(), border);
Border3D border = region.getBorderForFacet(ElevationFacet.class);
ElevationFacet facet = new ElevationFacet(region.getRegion(), border);

// loop through every position on our 2d array
Rect2i processRegion = facet.getWorldRegion();
Expand All @@ -50,6 +50,6 @@ public void process(GeneratingRegion region) {
}

// give our newly created and populated facet to the region
region.setRegionFacet(SurfaceHeightFacet.class, facet);
region.setRegionFacet(ElevationFacet.class, facet);
}
}