Skip to content

fix: Authentication with Microsoft SSO by sanitizeAccountData function for OAuth account linking#153

Merged
therealbrad merged 2 commits intoTestPlanIt:mainfrom
clFaster:main
Mar 26, 2026
Merged

fix: Authentication with Microsoft SSO by sanitizeAccountData function for OAuth account linking#153
therealbrad merged 2 commits intoTestPlanIt:mainfrom
clFaster:main

Conversation

@clFaster
Copy link
Copy Markdown
Contributor

@clFaster clFaster commented Mar 26, 2026

Description

  • Fix Authentication with Microsoft SSO
    • Azure AD (azure-ad) returns extra OAuth token fields during sign-in, including ext_expires_in.
    • Prisma Account model does not include ext_expires_in, so prisma.account.create() failed
    • Because account linking failed, Microsoft login was rejected even with valid credentials.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement

How Has This Been Tested?

Describe the tests you ran to verify your changes:

  • Unit tests
  • Integration tests
  • E2E tests
  • Manual testing

Test Configuration:

  • OS:
  • Browser (if applicable):
  • Node version:

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have signed the CLA

Additional Notes

@clFaster clFaster changed the title feat: add sanitizeAccountData function for OAuth account linking fix: Authentication with Microsoft SSO by sanitizeAccountData function for OAuth account linking Mar 26, 2026
@therealbrad
Copy link
Copy Markdown
Contributor

@clFaster Please indicate that you agree to the CLA before I accept the PR.

@therealbrad therealbrad merged commit 0c79039 into TestPlanIt:main Mar 26, 2026
1 check passed
@therealbrad
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.18.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

clFaster pushed a commit to clFaster/testplanit that referenced this pull request Mar 27, 2026
## [0.18.6](TestPlanIt/testplanit@v0.18.5...v0.18.6) (2026-03-26)

### Bug Fixes

* Authentication with Microsoft SSO by sanitizeAccountData function for OAuth account linking ([TestPlanIt#153](TestPlanIt#153)) ([0c79039](TestPlanIt@0c79039))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants