enhancement: dialog polish, share link password policy, and review field fixes#228
Merged
therealbrad merged 5 commits intomainfrom Apr 19, 2026
Merged
enhancement: dialog polish, share link password policy, and review field fixes#228therealbrad merged 5 commits intomainfrom
therealbrad merged 5 commits intomainfrom
Conversation
…eld fixes - Static height for tabbed dialogs (ShareDialog, EditProject) - CreateProjectWizard template step uses full height, removed Selected/Use Default buttons - Share link passwords now validate against admin password policy with PasswordStrengthIndicator on create and edit dialogs - Generate wizard review hides fields with null/empty values - Updated hardcoded '4 characters' strings to policy-aware messages - Updated E2E tests for new password validation messages Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The upgrade notification message field contained raw HTML tags from the notification definitions. When rendered in the daily digest email via Handlebars (which escapes HTML by default), the tags appeared as literal text. Strip HTML for the plain text message field; the rich HTML is preserved separately in data.htmlContent for in-app display. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that HTML tags are properly stripped from notification messages to prevent raw HTML appearing in digest emails. Tests confirm all notification messages produce clean plain text after stripping. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Loop stripHtml until no tags remain to handle nested/malformed tags (CodeQL CWE-20). Fix unused variable and eslint-disable directive. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 0.22.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dialog polish, share link password policy enforcement, and generate wizard review improvements.
h-[90vh]) for tabbed dialogs (ShareDialog, EditProject) to prevent layout shifts between tabsRelated Issue
Partially addresses #227 (password policy strings)
Type of Change
How Has This Been Tested?
Test Configuration:
Checklist
Screenshots (if applicable)
Additional Notes