fix: close the Client's aio session if the websocket fails to connect #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #49
Another option is to fix this in Textual itself; you can remove the guard here:
https://github.com/Textualize/textual/blob/3427dbaed666a9af926c711c0eed552260738cd2/src/textual/app.py#L3605-L3606
and just call
self._disconnect_devtools(), since that checks for the presence of devtools (but doesn't check if it's connected).A third option is to call
self_disconnect_devtools()when handling the exception raised by the connection failure:https://github.com/Textualize/textual/blob/3427dbaed666a9af926c711c0eed552260738cd2/src/textual/app.py#L3212-L3213