Skip to content

Added typing for watch callbacks #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

Added typing for watch callbacks #1929

merged 1 commit into from
Mar 3, 2023

Conversation

@willmcgugan
Copy link
Member

@willmcgugan willmcgugan commented Mar 3, 2023 •
edited
Loading

Fixes #1805

I think we might adopt a policy of requiring a comment explaining why type: ignore was necessary.

rodrigogiraoserrao
rodrigogiraoserrao approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@rodrigogiraoserrao rodrigogiraoserrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I did leave a question about ParamSpec, but that is because I don't know how it works.

@rodrigogiraoserrao
Copy link
Contributor

I think we might adopt a policy of requiring a comment explaining why type: ignore was necessary.

I like this.

@willmcgugan willmcgugan merged commit cb84d91 into main Mar 3, 2023
@willmcgugan willmcgugan deleted the fix-watch-callback-typing branch March 3, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rodrigogiraoserrao rodrigogiraoserrao rodrigogiraoserrao approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wrong type hint of DOMNode.watch method

3 participants

@willmcgugan @rodrigogiraoserrao