Skip to content

Implement border (sub)title. #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Mar 22, 2023
Merged

Implement border (sub)title. #2064

merged 37 commits into from
Mar 22, 2023

Conversation

@rodrigogiraoserrao
Copy link
Contributor

This will close #1864.

@rodrigogiraoserrao rodrigogiraoserrao added the enhancement New feature or request label Mar 14, 2023
@rodrigogiraoserrao rodrigogiraoserrao self-assigned this Mar 14, 2023
@willmcgugan
Copy link
Member

@rodrigogiraoserrao would you mind adding a screenshot or two of a widget with title / subtitle.

willmcgugan
willmcgugan requested changes Mar 15, 2023
View reviewed changes
Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good first pass. A few requests. Might be worth going over this tomorrow.

@rodrigogiraoserrao
Copy link
Contributor Author

_borders_example

@rodrigogiraoserrao
Copy link
Contributor Author

I think this still needs a couple of tests for edge cases (narrow spaces, flush against the edge, etc).

New demo:

Untitled

@rodrigogiraoserrao
Copy link
Contributor Author

@willmcgugan because I was catenating lists left, right, and centre, I reworked the two methods in _border.py to return iterables (to yield pieces one by one).
Let me know if this is not ok.

@rodrigogiraoserrao
Copy link
Contributor Author

Untitled

Run this demo with textual run docs/examples/styles/border_sub_title_align_all.py

willmcgugan
willmcgugan requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few requests.

@willmcgugan willmcgugan merged commit 2a810f8 into main Mar 22, 2023
@willmcgugan willmcgugan deleted the border-title branch March 22, 2023 11:07
rodrigogiraoserrao added a commit that referenced this pull request Mar 22, 2023
@rodrigogiraoserrao
Fix missing border example.
9c672e6 
Related issues: #2108
Related PRs: #2064
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Mar 22, 2023
Merged
rodrigogiraoserrao added a commit that referenced this pull request Mar 22, 2023
@rodrigogiraoserrao
Improve subsection titles.
f9922eb 
Related issues: #2108
Related PRs: #2110, #2064
@rodrigogiraoserrao rodrigogiraoserrao mentioned this pull request Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrenburns darrenburns Awaiting requested review from darrenburns

@davep davep Awaiting requested review from davep

@willmcgugan willmcgugan Awaiting requested review from willmcgugan

Assignees

@rodrigogiraoserrao rodrigogiraoserrao

Labels

enhancement New feature or request Task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add title to CSS borders

3 participants

@rodrigogiraoserrao @willmcgugan